I've tried it out, some feedback on the usability:

• Why does it show a green | character in front of the input sometimes? It is rather confusing
• The entered code is always red, even though it is totally valid. Arguably this shouldn't even do much validation itself, as people might be using their own wordlists.
• NO RECORDS FOUND is inaccurate. It also appears before even typing any characters. Maybe that message can be removed?

I think the bar idicates that the selection menu is active? The code should turn green when it has a number and at least two valid words in it. Yes "NO RECORDS FOUND" is not the ideal wording here. I have not looking into docs on how i can change this. I will see what we can do about it.

I am currently thinking about how we can refactor the completion part into wordlist. I get problems with reedline because reedline uses also the pos variable and not the whole line. Either we just complete the whole line step by step each time, or we use pos and complete each word independently depending on pos like it is now. Which approach would be the best? Probably the full line complete like the get_completions fn we've already got right? Need to test to find out if this works. Right now the user is able to move the cursor back and change a word in the middle. But i think this is not really needed right?

Right now the user is able to move the cursor back and change a word in the middle. But i think this is not really needed right?

I find it rather unrealistic that one would need to do such a thing.

However I don't really care much, you can add an optional pos parameter too if you feel like it. Something like

pub fn get_completions(&self, prefix: &str, pos: Option<usize>) -> Vec<String>;

where if pos is not set, it will use the prefix len?

Alternatively you can just return no completions to reedline if pos != len - 1 and use the existing signature.

If you add additional dependencies to the library crate for completions, please add them behind a feature flag (could call it completion) :)

I've switched to dialoguer crate. Keep it simple. But i think i found a little bug in dialoguer crate. When i move the cursor to the left in a word and tab complete it messes up the prefix text somehow. I think i need to open a bug report in dialoguer repo for that 👀.

And what am i missing with the fuzzy-complete feature with our tests? Classic case of it worked on my machine 🤣...

@felinira When i run cargo test --no-default-features --package magic-wormhole i get a pretty ugly error message from eyre:

error[E0432]: unresolved import `crate::transit`
  --> src\core\test.rs:9:5
   |
9  |     transit, AppConfig, AppID, Code, Wormhole, WormholeError,
   |     ^^^^^^^ no `transit` in the root
   |
note: found an item that was configured out
  --> src\lib.rs:37:9
   |
37 | pub mod transit;
   |         ^^^^^^^
note: the item is gated behind the `transit` feature
  --> src\lib.rs:36:7
   |
36 | #[cfg(feature = "transit")]
   |       ^^^^^^^^^^^^^^^^^^^

error[E0433]: failed to resolve: could not find `transit` in the crate root
  --> src\core\test.rs:46:51
   |
46 | pub(crate) fn log_transit_connection(info: crate::transit::TransitInfo) {
   |                                                   ^^^^^^^ could not find `transit` in the crate root
   |
note: found an item that was configured out
  --> src\lib.rs:37:9
   |
37 | pub mod transit;
   |         ^^^^^^^
note: the item is gated behind the `transit` feature
  --> src\lib.rs:36:7
   |
36 | #[cfg(feature = "transit")]
   |       ^^^^^^^^^^^^^^^^^^^

error[E0433]: failed to resolve: use of undeclared crate or module `transfer`
  --> src\core\test.rs:96:24
   |
96 | ) -> eyre::Result<Vec<(transfer::offer::OfferSend, transfer::offer::OfferAccept)>> {
   |                        ^^^^^^^^ use of undeclared crate or module `transfer`

error[E0433]: failed to resolve: use of undeclared crate or module `transfer`
  --> src\core\test.rs:96:52
   |
96 | ) -> eyre::Result<Vec<(transfer::offer::OfferSend, transfer::offer::OfferAccept)>> {
   |                                                    ^^^^^^^^ use of undeclared crate or module `transfer`

error[E0433]: failed to resolve: use of undeclared crate or module `transfer`
  --> src\core\test.rs:99:24
   |
99 |     ) -> eyre::Result<(transfer::offer::OfferSend, transfer::offer::OfferAccept)> {
   |                        ^^^^^^^^ use of undeclared crate or module `transfer`
...

Do we need to rethink how we use the default features in magic-wormhole package for the whole conditional fuzzy-complete feature to be variable with no-default-features? Maybe it would be better to use no-fuzzy-complete as a feature instead of fuzzy-complete inside default.

Do we need to rethink how we use the default features in magic-wormhole package

Yeah, that's on my list in my head for the next breaking change which would be 0.8. The entire crate needs a spring cleaning, which is easier once we have removed all deprecated items. I would however prefer to not do another breaking release for a little while longer, as it's always more work than anticipated. I don't have much time for it until EOY at least.

The empty feature build should also be properly tested in CI. But as this also occurs in main I would consider it out of scope for this PR. But feel free to submit a PR, I suppose we need to branch 0.8 eventually.

I will get #257 in first, because I would consider it a security fix, I hope it doesn't create too many conflicts.

Thanks a lot, it works well for now, at least for me :)